Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Tue, 2017-10-17 at 09:34 +0200, Toke Høiland-Jørgensen wrote: > >> Yeah, I did that initially. The reason I ended up squashing them is >> that >> this patch moved the per-station 'airtime' debugfs-entry that was >> previously created by ath9k into mac80211. I assumed it would create >> problems if both the driver and mac80211 tried to create the same >> file; >> not sure how to handle that if it's split into two patches? > > That might indeed be problematic, so perhaps just use a different > name? Well I would like to keep compatibility with my tooling that reads the values :) > Then again, if adding the entry fails in ath9k, nothing will happen > since it doesn't even check the return value - so I think it doesn't > actually matter. Right, I'll try that, and otherwise create a separate patch to ath9k that removes the debugfs entry before applying the mac80211 patch. >> > I'd prefer this were called "airtime" or such, >> >> Right. I picked rx_time for symmetry with the tx side; should I >> rename that as well, then, or is asymmetry fine? > > Let's not change the tx side in this patch, but we can clean it up > later I guess. ACK. -Toke
