On Mon, 2017-10-16 at 11:48 +0300, Sergey Matyukevich wrote: > > Well, monitor mode support in qtnfmac is in our todo list for sure. Sure. I'm saying you don't really need full monitor support at all, just a pure software construct for this. > Meanwhile the purpose of the patch was not to implement a full- > fledged mgmt packet capture. We have monitor mode and mature capture > tools for that. Right, and I didn't originally see the patch as such, just that the discussion (and in particular Julian's suggestion) veered off in that direction. > Nevertheless in certain cases it is handy to dump selected types of > mgmt frames while system is up and running without adding the whole > monitor overhead. The idea was that NL80211_CMD_REGISTER_FRAME and iw > are the right tools for that task. Anyway, iw is something like a > 'swiss-army-knife' tool for various tasks related to > mac80211/cfg80211 reporting and troubleshooting. I'd see this particular feature in iw more as a way to debug the registrations, but whatever you ultimately want to use it for I neither can nor want to control :-) > Let me know if you have any objections to implementation details :) Yeah, I'll need to review it, just need a bit more time for that. > Then I will resubmit it addressing all the comments. Besides I am > going to change command name from 'capture' to 'dump' to avoid > confusion. Finally, I will update commit message adding information > about unicast nature of those registrations. Sounds good :) Do you want to resend before I review it? johannes
