Variable val is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas <chris.gekas@xxxxxxxxx> --- drivers/net/wireless/ath/ath10k/spectral.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/spectral.c b/drivers/net/wireless/ath/ath10k/spectral.c index dd9cc09..1867937 100644 --- a/drivers/net/wireless/ath/ath10k/spectral.c +++ b/drivers/net/wireless/ath/ath10k/spectral.c @@ -403,10 +403,7 @@ static ssize_t write_file_spectral_count(struct file *file, return -EFAULT; buf[len] = '\0'; - if (kstrtoul(buf, 0, &val)) - return -EINVAL; - - if (val < 0 || val > 255) + if (kstrtoul(buf, 0, &val) || val > 255) return -EINVAL; mutex_lock(&ar->conf_mutex); -- 2.7.4
