silexcommon@xxxxxxxxx writes: > From: Alagu Sankar <alagusankar@xxxxxxxxxxxxxxx> > > convert different read write functions in sdio hif to bring it under a > single read-write path. This helps in having a common dma bounce buffer > implementation. Also helps in address modification that is required > specific to change in certain mbox addresses of sdio_write. > > Signed-off-by: Alagu Sankar <alagusankar@xxxxxxxxxxxxxxx> This didn't compile for me: drivers/net/wireless/ath/ath10k/sdio.c:320:12: error: conflicting types for 'ath10k_sdio_read' drivers/net/wireless/ath/ath10k/sdio.c:39:12: note: previous declaration of 'ath10k_sdio_read' was here drivers/net/wireless/ath/ath10k/sdio.c:365:12: error: conflicting types for 'ath10k_sdio_write' drivers/net/wireless/ath/ath10k/sdio.c:41:12: note: previous declaration of 'ath10k_sdio_write' was here drivers/net/wireless/ath/ath10k/sdio.c:39:12: warning: 'ath10k_sdio_read' used but never defined drivers/net/wireless/ath/ath10k/sdio.c:41:12: warning: 'ath10k_sdio_write' used but never defined gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 I fixed it like below in the pending branch. But I'll review more carefully later, I have quite a lot of patches pending right now. --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -37,9 +37,9 @@ #define ATH10K_SDIO_DMA_BUF_SIZE (32 * 1024) static int ath10k_sdio_read(struct ath10k *ar, u32 addr, void *buf, - u32 len, bool incr); + size_t len, bool incr); static int ath10k_sdio_write(struct ath10k *ar, u32 addr, const void *buf, - u32 len, bool incr); + size_t len, bool incr); /* inlined helper functions */ -- Kalle Valo
