Amitkumar Karwar <amitkarwar@xxxxxxxxx> writes:
> From: Karun Eagalapati <karun256@xxxxxxxxx>
>
> We are disabling of interrupts from firmware in freeze handler.
> Also setting power management capability KEEP_MMC_POWER to make
> device wakeup for WoWLAN trigger.
> At restore, we observed a device reset on some platforms. Hence
> reloading of firmware and device initialization is performed.
With "reloading of firmware and device initialization" you mean calling
rsi_mac80211_detach()?
void rsi_mac80211_detach(struct rsi_hw *adapter)
{
struct ieee80211_hw *hw = adapter->hw;
enum nl80211_band band;
if (hw) {
ieee80211_stop_queues(hw);
ieee80211_unregister_hw(hw);
ieee80211_free_hw(hw);
}
That looks like a quite heavy sledgehammer workaround to a resume
problem. Is it really the best way to handle this?
And even if that would be the right approach it needs to be properly
described in the commit log, a vague sentence in the end of a commit log
is not enough.
--
Kalle Valo
