On Wed, 2017-09-20 at 17:08 +0100, Colin Ian King wrote: > Johannes, > > Static analysis with CoverityScan on linux-next today detected a null > pointer dereference issue on commit: > > From 0fc4b3403d215ecd3c05505ec1f0028a227ed319 Mon Sep 17 00:00:00 > 2001 > From: Johannes Berg <johannes.berg@xxxxxxxxx> > Date: Thu, 22 Jun 2017 12:20:29 +0200 > Subject: [PATCH] mac80211: avoid allocating TXQs that won't be used > > Issue: sdata is null when the sdata is dereferenced by: > > sdata->vif.type != NL80211_IFTYPE_AP_VLAN && > sdata->vif.type != NL80211_IFTYPE_MONITOR) > > note that sdata is assigned a non-null much later with the statement > sdata = netdev_priv(ndev). Yeah, umm, that should be checking just 'type'. Thanks, will fix. johannes
