Hi, > -----Original Message----- > From: Arend van Spriel [mailto:arend.vanspriel@xxxxxxxxxxxx] > Sent: 2017年9月20日 16:40 > To: Xinming Hu <huxinming820@xxxxxxxxx>; Linux Wireless > <linux-wireless@xxxxxxxxxxxxxxx> > Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>; Brian Norris > <briannorris@xxxxxxxxxx>; Dmitry Torokhov <dtor@xxxxxxxxxx>; > rajatja@xxxxxxxxxx; Zhiyuan Yang <yangzy@xxxxxxxxxxx>; Tim Song > <songtao@xxxxxxxxxxx>; Cathy Luo <cluo@xxxxxxxxxxx>; Ganapathi Bhat > <gbhat@xxxxxxxxxxx>; Xinming Hu <huxm@xxxxxxxxxxx> > Subject: [EXT] Re: [PATCH] mwifiex: add device specific ioctl handler > > External Email > > ---------------------------------------------------------------------- > On 9/20/2017 8:44 AM, Xinming Hu wrote: > > From: Xinming Hu <huxm@xxxxxxxxxxx> > > > > Add net_dev ndo_do_ioctl handler, which could be used for downloading > > host command by utility in manufactory test > > Not sure if we want ioctls in upstream wireless drivers. Yes, wext ioctl could be discard and replaced by well defined nl80211/cfg80211. But per my understand, the net device ioctl will still works normally. Right ? > You could look at > nl80211 vendor commands, but that is also under scrutiny if common wifi > functionality is provided by it. I am pretty sure Kalle has his ideas about this :-) > Yes, the new utility should use nl80211 interface. But we have lots of legacy utility based on ioctl, it will be helpful to reduce massive work on refactoring. > Regards, > Arend