On Mon, Sep 18, 2017 at 12:03:07PM +0200, Johannes Berg wrote: > > > > - if (timer_pending(&mac->scan_timeout)) > > > > - del_timer_sync(&mac->scan_timeout); > > > > qtnf_scan_done(mac, le32_to_cpu(status->flags) & > > > > QLINK_SCAN_ABORTED); > > > > > > and that's related perhaps but not really explained in the > > > changelog, > > > not sure? > > > > That was minor optimization: to remove pedning timer whenever scan > > is canceled. Sure, it worth mentioning in changelog, will do. > > I realized (after sending my email) that it actually made a lot of > sense, so yeah - and in fact I'm not sure it's just an optimisation, > depends on where else you cancel the timer and if that could leave the > timer running until after the interface is removed or something. > > Btw, I don't really see why you check pending first? I don't quite understand the question. Do you mean it makes sense to call cfg80211_scan_done first and then cancel timer ? > > By the way, is it ok to send corrected single patch in reply to this > > discussion ? Or the appropriate way is to resend the whole patch set > > ? > > Good question. I think it's up to the specific maintainer, I know davem > wants a full resend, but Kalle might have his own preference. I for one > am willing to deal with both, though a full resend is somewhat easier. Ok, understood. Regards, Sergey
