Am 08.09.2017 um 08:55 schrieb Johannes Berg:
On Thu, 2017-09-07 at 17:47 +0200, Richard Schütz wrote:
Use IEEE80211_RATE_MANDATORY_G instead of IEEE80211_RATE_MANDATORY_B
for comparison to get all mandatory rates in 2.4 GHz band. It is safe
to do so because ERP mandatory rates are a superset of HR/DSSS
mandatory rates.
This I don't understand - what "comparison" are you talking about?
Sorry, I meant the condition that checks for the presence of
mandatory_flag at the bottom of the function.
Also force IEEE80211_RATE_MANDATORY_A for 10 MHz and 5 MHz channels
as they use "half-clocked" respectively "quarter-clocked" operation
of the OFDM rates (IEEE Std 802.11-2016, 17.1.1).
I don't think this is correct - the way the flags are used, anything on
2.4 GHz would never bother to check the MANDATORY_A flag.
Do we actually allow 10 MHz and 5 MHz operation in the 2.4 GHz band? As
far as I can tell that has only been specified for OFDM PHYs, which use
the 5 GHz band and are covered by IEEE80211_RATE_MANDATORY_A, but I am
not a hundred per cent sure about that. Cc'ing Simon Wunderlich who
originally implemented checking of scan_width here.
The main intention of this patch series is to fix mandatory rates
returned for normal operation in 2.4 GHz band. Currently only 1 Mb/s is
returned here, which is wrong for both HR/DSSS and ERP PHYs.
--
Richard
