On 22-08-17 13:25, Ian Molton wrote:
This introduces no functional changes, but makes the code drastically more readable, reducing the amount of dereferencing performed inside functions throughout the SDIO core. For example, reduce: sdio_release_host(bus->sdiodev->func1); to: sdio_release_host(func1);
I still have problems with this change. The example above does not convince me. I explained my rule of thumb regarding using dereferences and will stick to that.
Fixup a few inconsistently named pointers whilst we are at it ie. sdiod -> sdiodev Signed-off-by: Ian Molton <ian@xxxxxxxxxxxxxx> Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> --- .../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 140 +++---- .../wireless/broadcom/brcm80211/brcmfmac/sdio.c | 406 +++++++++++---------- 2 files changed, 293 insertions(+), 253 deletions(-)
All I see is 40 more lines to read. Regards, Arend
