Search Linux Wireless

Re: [PATCH 1/2] iwlwifi: fix long debug print

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Joe Perches <joe@xxxxxxxxxxx> writes:

> On Fri, 2017-09-01 at 08:37 +0300, Luca Coelho wrote:
>> On Thu, 2017-08-31 at 14:57 -0700, Joe Perches wrote:
>> > On Fri, 2017-08-25 at 11:27 +0300, Luca Coelho wrote:
>> > > From: Liad Kaufman <liad.kaufman@xxxxxxxxx>
>> > > 
>> > > There is a debug print that sometimes reaches over
>> > > 110 chars, thus generating a warning in those cases.
>> > 
>> > What emits a warning here?
>> 
>> We have a WARN_ON in iwl-devtrace-msg.h:
>> 
>> #define MAX_MSG_LEN	110
>
> OK, thanks for the hint.
>
> The commit message is a bit obscure.
>
> It might make sense to add a comment to describe these
> trace events coming from TRACE_EVENT(iwlwifi_dbg,
>
> All the IWL_DEBUG_<foo> use this trace message maximum.

Unfortunately the patch is already commited to wireless-drivers-next so
we can't change the commit log anymore.

-- 
Kalle Valo



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux