Search Linux Wireless

Re: [PATCH 18/30] brcmfmac: Cleanup offsetof()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>, linux-wireless@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 18/30] brcmfmac: Cleanup offsetof()
From: Ian Molton <ian@xxxxxxxxxxxxxx>
Date: Thu, 31 Aug 2017 16:37:02 +0100
In-reply-to: <c4412aaa-1c66-44d5-1f0b-cc208aad7e60@broadcom.com>
References: <20170822112550.60311-1-ian@mnementh.co.uk> <20170822112550.60311-19-ian@mnementh.co.uk> <c4412aaa-1c66-44d5-1f0b-cc208aad7e60@broadcom.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 30/08/17 20:37, Arend van Spriel wrote:
> On 22-08-17 13:25, Ian Molton wrote:
>> +#define __sd_reg(field) \
>> +        (offsetof(struct sdpcmd_regs, field))
> 
> I really dislike __foo() stuff. Please just stick with uppercase for
> macros, so SD_REG(). I am fine with dropping the base here.

I'm fine with that. Will change.

-Ian

References:
- [PATCH v5] brcmfmac cleanup
  - From: Ian Molton
- [PATCH 18/30] brcmfmac: Cleanup offsetof()
  - From: Ian Molton
- Re: [PATCH 18/30] brcmfmac: Cleanup offsetof()
  - From: Arend van Spriel

Prev by Date: Re: [PATCH 13/30] brcmfmac: Clarify if using braces.
Next by Date: Re: [PATCH] wl1251: add a missing spin_lock_init()
Previous by thread: Re: [PATCH 18/30] brcmfmac: Cleanup offsetof()
Next by thread: [PATCH 20/30] brcmfmac: Remove repeated calls to brcmf_chip_get_core()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]

Powered by Linux