On 08/30/2017 09:28 AM, Kalle Valo wrote:
External Email
Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes:
Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes:
igor.mitsyanko.os@xxxxxxxxxxxxx writes:
This patchset has a goal to make operational parameters (channel, BW,
HT/VHT capabilities) configuration possible for qtnfmac driver.
Basically the idea is to make driver level as thin as possible, and let
everything to be handled by userspace/nl80211 and wireless device itself.
This patchset is just too big and pain to review. Preferably no more
than 10-12 patches per set, please. If the patches bigger then the limit
should be even lower.
And I noticed that patch 25 didn't make it to patchwork:
https://patchwork.kernel.org/project/linux-wireless/list/?state=*&q=qtnfmac
Actually it did but it was an nl80211 patch:
https://patchwork.kernel.org/patch/9921179/
Never ever hide mac80211 or cfg80211 patches within driver patches like
this. They need to be submitted separately so that everyone sees them.
In some cases it makes sense to submit the driver patches using the new
cfg80211/mac80211 feature at the same, but then do it so that you have
the cfg80211/mac80211 patches and the corresponding driver patches as
last. In that case I assign the whole patchset first to Johannes and
once he has applied the cfg80211/mac80211 patches he assigns the driver
patches to me.
Ok, understood.
--
Kalle Valo
