On 07/08/17 12:26, Arend van Spriel wrote: > > Needing this debugging does not necessarily means you are doing > something wrong. You may be dealing with hardware that is doing > something wrong and when that happens this debug can be useful. I > frankly hardly ever enable SDIO debug level unless I am in that > scenario. Maybe adding a debug level for low-level access would be > useful to reduce the noise for SDIO debug level. Perhaps, but its only actually called from a half dozen or so places in the code + the buscore_*32 entrypoints. All it actually does now is ensure the address window is right and call the Linux SDIO core readl method. if we can't trust that, we're kinda screwed anyway. If we later bring the SDIO code in line with the PCIe code, it wont even do the address window checking (it'll just assume its already correct). We can always enable the SDIO core lowlevel debug if we really want to see register level acceses. -Ian
