On Sun, 2017-06-25 at 10:43 -0500, Larry Finger wrote: > From: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > Use debugfs to dump register and btcoex status. [] > diff --git a/drivers/net/wireless/realtek/rtlwifi/debug.c b/drivers/net/wireless/realtek/rtlwifi/debug.c [] > +void rtl_debug_add_one(struct ieee80211_hw *hw) > +{ > + struct rtl_priv *rtlpriv = rtl_priv(hw); > + struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw)); > + struct dentry *parent; > + > + snprintf(rtlpriv->dbg.debugfs_name, 18, "%02x-%02x-%02x-%02x-%02x-%02x", > + rtlefuse->dev_addr[0], rtlefuse->dev_addr[1], > + rtlefuse->dev_addr[2], rtlefuse->dev_addr[3], > + rtlefuse->dev_addr[4], rtlefuse->dev_addr[5]); Why uses dashes and why not just use %pM