Maya Erez <qca_merez@xxxxxxxxxxxxxxxx> writes:
> From: Gidon Studinski <qca_gidons@xxxxxxxxxxxxxxxx>
>
> Since debugfs is a kernel configuration option, enable the driver to
> compile without debugfs.
>
> Signed-off-by: Gidon Studinski <qca_gidons@xxxxxxxxxxxxxxxx>
> Signed-off-by: Maya Erez <qca_merez@xxxxxxxxxxxxxxxx>
> ---
> drivers/net/wireless/ath/wil6210/Makefile | 2 +-
> drivers/net/wireless/ath/wil6210/wil6210.h | 6 ++++++
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wil6210/Makefile b/drivers/net/wireless/ath/wil6210/Makefile
> index 4ae21da..63a751a 100644
> --- a/drivers/net/wireless/ath/wil6210/Makefile
> +++ b/drivers/net/wireless/ath/wil6210/Makefile
> @@ -4,7 +4,7 @@ wil6210-y := main.o
> wil6210-y += netdev.o
> wil6210-y += cfg80211.o
> wil6210-y += pcie_bus.o
> -wil6210-y += debugfs.o
> +wil6210-$(CONFIG_DEBUG_FS) += debugfs.o
> wil6210-y += wmi.o
> wil6210-y += interrupt.o
> wil6210-y += txrx.o
> diff --git a/drivers/net/wireless/ath/wil6210/wil6210.h b/drivers/net/wireless/ath/wil6210/wil6210.h
> index cf20a8c..d7b1e03 100644
> --- a/drivers/net/wireless/ath/wil6210/wil6210.h
> +++ b/drivers/net/wireless/ath/wil6210/wil6210.h
> @@ -940,8 +940,14 @@ int wil_cfg80211_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *wdev,
> struct cfg80211_mgmt_tx_params *params,
> u64 *cookie);
>
> +#if defined(CONFIG_DEBUG_FS)
> int wil6210_debugfs_init(struct wil6210_priv *wil);
> void wil6210_debugfs_remove(struct wil6210_priv *wil);
> +#else
> +static inline int wil6210_debugfs_init(struct wil6210_priv *wil) { return 0; }
> +static inline void wil6210_debugfs_remove(struct wil6210_priv *wil) {}
> +#endif
I was thinking more that should we have CONFIG_WIL6210_DEBUGFS, just
like we have CONFIG_ATH10K_DEBUGFS and CONFIG_ATH9K_DEBUGFS? This way it
can be controlled per driver if debugfs interface is available or not.
--
Kalle Valo
