On 07/08/17 12:26, Arend van Spriel wrote: > On 7/26/2017 10:25 PM, Ian Molton wrote: >> Primarily this patch removes: >> >> brcmf_sdiod_f0_writeb() >> brcmf_sdiod_reg_write() >> brcmf_sdiod_reg_read() > > Having [patch 30/34] "brcmfmac: Correctly handle accesses to SDIO func0" > before this patch could make this look cleaner. This is an artifact of how I came to the realisation the code was using the obsoleted functions - it could be reordered, but it'd probably get messy... >> Since we no longer use the quirky method of deciding which function to >> address via the address being accessed, take the opportunity to rename >> some IO functions more in line with common kernel code. > > As mentioned here this is more a rename than a replace so please use > that in the subject as well. Noted. > Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> >> Signed-off-by: Ian Molton <ian@xxxxxxxxxxxxxx> >> --- >> .../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 166 >> +++---------------- >> .../wireless/broadcom/brcm80211/brcmfmac/sdio.c | 182 >> ++++++++++----------- >> .../wireless/broadcom/brcm80211/brcmfmac/sdio.h | 28 +++- >> 3 files changed, 132 insertions(+), 244 deletions(-) > -Ian
