On 07/08/17 12:25, Arend van Spriel wrote: > On 26-07-17 22:25, Ian Molton wrote: >> This large function is concealing a LOT of obscure logic about >> how the hardware functions. Time to split it up. >> >> This first patch splits the function into two pieces - read and write, >> doing away with the rw flag in the process. > > I really don't this it is all that obscure, but alas. Everything is in > the eye of the beholder. The reason for having the helper was to not > duplicate code for read and write and different access sizes. So now you > are duplicating it. In subsequent patches you throw away pieces of this > helper so duplication is not as bad in the net result. It would have > been easier if those patches were done before this one. I agree, this is a big and unwieldy patchset - I've attempted to break the thing down in such a way that all the steps leading to the end result are at least sane. I initially did it all in one hit and it was utterly illegible :-( > Fix the indent and column align to opening bracket. I guess a few of these got through. I blame git rebase :) -Ian
