Luca Coelho <luca@xxxxxxxxx> writes: > On Mon, 2017-08-07 at 16:11 +0300, Kalle Valo wrote: >> Luca Coelho <luca@xxxxxxxxx> writes: >> >> > From: Chaya Rachel Ivgi <chaya.rachel.ivgi@xxxxxxxxx> >> > >> > In order to test the enter/exit CT-kill flow. >> > >> > Signed-off-by: Chaya Rachel Ivgi <chaya.rachel.ivgi@xxxxxxxxx> >> > Signed-off-by: Luca Coelho <luciano.coelho@xxxxxxxxx> >> >> The commit log doesn't explain what's CT-kill and how/where it could be >> used. For example, I have no clue what this could be about. > > You're right, sorry for that. I'll update the commit log and submit v2. > > Basically CT-kill is a thermal "RF-kill". Whenever the NIC gets too > hot, we shut it down to prevent further damage. This is nothing new. > What this patch is adding is a fake way to simulate the NIC getting too > hot by kicking off a debugfs entry, in the same way the FW would kick it > off by sending a notification to the driver. > > This is mostly for R&D, but it's very useful for us and I we need it for > our internal tests. Not that useful for non-developers but I didn't > want to carry this in internal driver to avoid unnecessary conflicts > when syncing it with upstream. Thanks, makes sense now. -- Kalle Valo