On 7/26/2017 10:25 PM, Ian Molton wrote:
Unlikely to be a problem, but brcmf_sdiod_regrb() is not symmetric with brcmf_sdiod_regrl() in this regard.
You are pretty keen on symmetry, but you could also remove the initialization in brcmf_sdiod_regrl(). As long as no -Wunitialized pops up that would have my preference.
Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Signed-off-by: Ian Molton <ian@xxxxxxxxxxxxxx> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)