Hi!
On Thursday 19 June 2008, Holger Schurig wrote:
> There are no known firmwares for CF and SDIO based devices that
> support MESH. For those devices, mesh-support in the driver is just
> a bit of bloat. Moreover, they're mostly used in embedded devices,
> where space counts.
>
> This patch saves about 10 kB in .text and 288 bytes in .data:
>
> 129542 4012 28 133582 209ce libertas.ko
> 119279 3724 28 123031 1e097 nomesh/libertas.ko
>
> 8142 840 0 8982 2316 libertas_cs.ko
> 8134 840 0 8974 230e nomesh/libertas_cs.ko
>
> 9516 700 8 10224 27f0 libertas_sdio.ko
> 9516 700 8 10224 27f0 nomesh/libertas_sdio.ko
>
> 10333 860 0 11193 2bb9 usb8xxx.ko
> 10333 860 0 11193 2bb9 nomesh/usb8xxx.ko
>
> Signed-off-by: Holger Schurig <hs4233@xxxxxxxxxxxxxxxxxxxx>
Looking at the numbers, this seems a good idea.
But, looking at the code, there are so many #ifdefs!
These #ifdefs have a cost:
* #ifdefs decrease code readability
* every future patch should be (compile AND runtime) tested with the mesh
code enable and disable.
IHMO, the cost versus benefits is far to high.
Best regards
Marc
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
