On Fri, 2008-06-20 at 01:22 +0200, Johannes Berg wrote: > +#define CALL_TXH(txh) \ > + res = txh(tx); \ > + if (res != TX_CONTINUE) \ > + goto txh_done; > + > + CALL_TXH(ieee80211_tx_h_check_assoc) > + CALL_TXH(ieee80211_tx_h_sequence); > + CALL_TXH(ieee80211_tx_h_ps_buf); > + CALL_TXH(ieee80211_tx_h_select_key); > + CALL_TXH(ieee80211_tx_h_michael_mic_add); > + CALL_TXH(ieee80211_tx_h_rate_ctrl); > + CALL_TXH(ieee80211_tx_h_misc); > + CALL_TXH(ieee80211_tx_h_fragment); > + /* handlers after fragment must be aware of tx info fragmentation! */ > + CALL_TXH(ieee80211_tx_h_encrypt); > + CALL_TXH(ieee80211_tx_h_calculate_duration); > + CALL_TXH(ieee80211_tx_h_stats); > +#undef CALL_TXH Unnecessary ; after each CALL_TXH()...except the first. Same thing for 3/3 on the receive side. Other than that (small) bit, looks ok at first glance. Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html