Stanislaw Gruszka <sgruszka@xxxxxxxxxx> writes: > On Wed, Aug 02, 2017 at 11:10:11AM +0200, Arend van Spriel wrote: >> On 8/2/2017 11:04 AM, Stanislaw Gruszka wrote: >> >For historic reasons we have separate cases for mic_fail and >> >mic_fail_no_key. But with current code we can merge those cases, >> >as we already have NULL key check since: >> > >> >commit a66b98db570a638afd909459e1e6bfa272344bd3 >> >Author: Arik Nemtsov <arik@xxxxxxxxxx> >> >Date: Thu Jun 23 00:00:24 2011 +0300 >> > >> > mac80211: fix rx->key NULL dereference during mic failure >> >> Maybe better to use: >> ... since commit a66b98db570a ("mac80211: fix rx->key NULL >> dereference during mic failure"). >> >> as it is the preferred method to reference git commits. > > Is easier for me to just copy-paste commit in form the git log/show > command provides, so I use that form. Is there tool or git log/show > option to get commit log in the preferred form, so I do not have to > change it manually? I do it like this: $ git show --format=fixes a66b98db570a638afd909459e1e6bfa272344bd3 | head -1 Fixes: a66b98db570a ("mac80211: fix rx->key NULL dereference during mic failure") How to configure it is documented in SubmittingPatches: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes -- Kalle Valo