Search Linux Wireless

Re: [PATCH 19/34] brcmfmac: Get rid of chip_priv and core_priv structs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ian,

[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v4.13-rc2 next-20170728]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ian-Molton/brcmfmac-Fix-parameter-order-in-brcmf_sdiod_f0_writeb/20170728-215756
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=parisc 

Note: the linux-review/Ian-Molton/brcmfmac-Fix-parameter-order-in-brcmf_sdiod_f0_writeb/20170728-215756 HEAD 279d46b037ee04966f44b25a0ed07c467540c68c builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c: In function 'brcmf_chip_recognition':
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:900:9: error: 'KERN_LOG' undeclared (first use in this function)
     printk(KERN_LOG "found %s chip: BCM%s, rev=%d\n",
            ^~~~~~~~
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:900:9: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:900:18: error: expected ')' before string constant
     printk(KERN_LOG "found %s chip: BCM%s, rev=%d\n",
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/KERN_LOG +900 drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c

   880	
   881	static int brcmf_chip_recognition(struct brcmf_chip *ci)
   882	{
   883		struct brcmf_core *core;
   884		u32 regdata;
   885		u32 socitype;
   886		int ret;
   887	
   888		/* Get CC core rev
   889		 * Chipid is assume to be at offset 0 from SI_ENUM_BASE
   890		 * For different chiptypes or old sdio hosts w/o chipcommon,
   891		 * other ways of recognition should be added here.
   892		 */
   893		regdata = ci->ops->read32(ci->ctx, CORE_CC_REG(SI_ENUM_BASE, chipid));
   894		ci->chip = regdata & CID_ID_MASK;
   895		ci->chiprev = (regdata & CID_REV_MASK) >> CID_REV_SHIFT;
   896		socitype = (regdata & CID_TYPE_MASK) >> CID_TYPE_SHIFT;
   897	
   898		brcmf_chip_name(ci->chip, ci->name, sizeof(ci->name));
   899	
 > 900		printk(KERN_LOG "found %s chip: BCM%s, rev=%d\n",
   901		       socitype == SOCI_SB ? "SB" : "AXI", ci->name, ci->chiprev);
   902	
   903		switch(socitype) {
   904			case SOCI_SB:
   905	
   906			if (ci->chip != BRCM_CC_4329_CHIP_ID) {
   907				brcmf_err("SB chip is not supported\n");
   908				return -ENODEV;
   909			}
   910			ci->iscoreup = brcmf_chip_sb_iscoreup;
   911			ci->coredisable = brcmf_chip_sb_coredisable;
   912			ci->resetcore = brcmf_chip_sb_resetcore;
   913	
   914			core = brcmf_chip_add_core(ci, BCMA_CORE_CHIPCOMMON,
   915						   SI_ENUM_BASE, 0);
   916			brcmf_chip_sb_corerev(ci, core);
   917			core = brcmf_chip_add_core(ci, BCMA_CORE_SDIO_DEV,
   918						   BCM4329_CORE_BUS_BASE, 0);
   919			brcmf_chip_sb_corerev(ci, core);
   920			core = brcmf_chip_add_core(ci, BCMA_CORE_INTERNAL_MEM,
   921						   BCM4329_CORE_SOCRAM_BASE, 0);
   922			brcmf_chip_sb_corerev(ci, core);
   923			core = brcmf_chip_add_core(ci, BCMA_CORE_ARM_CM3,
   924						   BCM4329_CORE_ARM_BASE, 0);
   925			brcmf_chip_sb_corerev(ci, core);
   926	
   927			core = brcmf_chip_add_core(ci, BCMA_CORE_80211, 0x18001000, 0);
   928			brcmf_chip_sb_corerev(ci, core);
   929			break;
   930		case SOCI_AXI:
   931			ci->iscoreup = brcmf_chip_ai_iscoreup;
   932			ci->coredisable = brcmf_chip_ai_coredisable;
   933			ci->resetcore = brcmf_chip_ai_resetcore;
   934	
   935			brcmf_chip_dmp_erom_scan(ci);
   936			break;
   937		default:
   938			brcmf_err("chip backplane type %u is not supported\n",
   939				  socitype);
   940			return -ENODEV;
   941		}
   942	
   943		ret = brcmf_chip_cores_check(ci);
   944		if (ret)
   945			return ret;
   946	
   947		/* assure chip is passive for core access */
   948		brcmf_chip_set_passive(ci);
   949	
   950		/* Call bus specific reset function now. Cores have been determined
   951		 * but further access may require a chip specific reset at this point.
   952		 */
   953		if (ci->ops->reset) {
   954			ci->ops->reset(ci->ctx, ci);
   955			brcmf_chip_set_passive(ci);
   956		}
   957	
   958		return brcmf_chip_get_raminfo(ci);
   959	}
   960	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux