Search Linux Wireless

Re: [PATCH] mwifiex: correct IE parse during association

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Xinming Hu <huxinming820@xxxxxxxxx> writes:

> From: Xinming Hu <huxm@xxxxxxxxxxx>
>
> It is observed that some IEs get missed during association.
> This patch correct the old IE parse code. sme->ie will be
> store as wpa ie, wps ie, wapi ie and gen ie accordingly.
>
> Signed-off-by: Xinming Hu <huxm@xxxxxxxxxxx>
> Signed-off-by: Cathy Luo <cluo@xxxxxxxxxxx>

[...]

> +		} else {
> +			if (pvendor_ie->element_id ==
> +			    WLAN_EID_VENDOR_SPECIFIC) {
> +				/* Test to see if it is a WPA IE,
> +				 * if not, then it is a gen IE
> +				 */
> +				if (!memcmp(pvendor_ie->oui, wpa_oui,
> +					    sizeof(wpa_oui))) {
> +					/* IE is a WPA/WPA2 IE so call
> +					 * set_wpa function
> +					 */
> +					mwifiex_set_wpa_ie(priv,
> +							   (u8 *)pvendor_ie,
> +							   cur_ie_len);

The indentation is getting ugly here. A helper function or similar would
really make this more readable.


[...]

> +NEXT_IE:

Goto labels in lower case, please.

-- 
Kalle Valo



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux