Larry Finger <Larry.Finger@xxxxxxxxxxxx> writes:
> From: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
>
> Use debugfs to dump register and btcoex status. The kbuild test robot
> <lkp@xxxxxxxxx> suggested a change to use simple_open() instead of
> a local routine.
>
> Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Cc: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx>
> Cc: Birming Chiu <birming@xxxxxxxxxxx>
> Cc: Shaofu <shaofu@xxxxxxxxxxx>
> Cc: Steven Ting <steventing@xxxxxxxxxxx>
[...]
> + if (count < 3) {
> + /*printk("argument size is less than 3\n");*/
> + return -EFAULT;
> + }
> + if (num != 3) {
> + /*printk("invalid write_reg parameter!\n");*/
> + return count;
> + }
> + default:
> + /*printk("error write length=%d", len);*/
> + break;
> + }
Dead code.
> + /* add for debug */
> + rtl_debug_add_one(hw);
> + /* remove form debug */
> + rtl_debug_remove_one(hw);
The comments are useless, the function name already tells the same.
--
Kalle Valo
