Hi Brian, > -----Original Message----- > From: Brian Norris [mailto:briannorris@xxxxxxxxxxxx] > Sent: 2017年7月20日 4:10 > To: Xinming Hu > Cc: Linux Wireless; Kalle Valo; Dmitry Torokhov; rajatja@xxxxxxxxxx; Zhiyuan > Yang; Tim Song; Cathy Luo; Xinming Hu > Subject: [EXT] Re: [PATCH] mwifiex: add tdls uapsd support module parameter > > External Email > > ---------------------------------------------------------------------- > On Wed, Jul 19, 2017 at 06:36:27AM +0000, Xinming Hu wrote: > > From: Xinming Hu <huxm@xxxxxxxxxxx> > > > > Add module parameter to control tdls uapsd support, which is default > > disabled. > > Why default disabled, when it looks like it used to be on by default? Oho, I should comment more in description, it is now confusing. We just fixed an tdls uapsd issue in latest firmware, so try to disable this feature as a workaround to the old firmware. At the same time, it is optional to enable this feature in specific case. I will add more comments in V2. Please let us know if you have more comments. Regards, Simon