On Thu, Jun 29, 2017 at 12:10 AM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
> Amitkumar Karwar <amitkarwar@xxxxxxxxx> writes:
>
>> From: Prameela Rani Garnepudi <prameela.j04cs@xxxxxxxxx>
>>
>> EEPROM read frame is sent during device initialization to read mac address.
>> The format of the frame is modified in firmware to include eeprom length
>> and offset. This frame does not return firmware version now. Also same
>> frame is sent again to read rf type and band information.
>>
>> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@xxxxxxxxx>
>> Signed-off-by: Amitkumar Karwar <amit.karwar@xxxxxxxxxxxxxxxxxx>
>
> [...]
>
>> --- a/drivers/net/wireless/rsi/rsi_main.h
>> +++ b/drivers/net/wireless/rsi/rsi_main.h
>> @@ -37,6 +37,7 @@ enum RSI_FSM_STATES {
>> FSM_COMMON_DEV_PARAMS_SENT,
>> FSM_BOOT_PARAMS_SENT,
>> FSM_EEPROM_READ_MAC_ADDR,
>> + FSM_EEPROM_READ_RF_TYPE,
>> FSM_RESET_MAC_SENT,
>> FSM_RADIO_CAPS_SENT,
>> FSM_BB_RF_PROG_SENT,
>
> Shouldn't you also update fsm_state array, just like Colin fixed earlier
> this week:
Thanks for pointing this out. This has been addressed in v3 series.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=58828680af495bc4863af3a006f2018c71714665
>
> I think a some kind of build time check for this is in order, should be
> doable with BUILD_BUG_ON().
>
Sure. I have created a separate patch for this in v3 series.
Regards,
Amitkumar
