Hi Kalle, On Wed, Jun 28, 2017 at 9:47 PM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > Souptick Joarder <jrdr.linux@xxxxxxxxx> writes: > >> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval >> and hw->max_rate_tries are replaced by macro. >> >> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx> >> --- >> Changes in v2: >> - Signed-off was missing in previous one. As Signed-off was missing in first patch, so I send v2 with change logs mentioned the same. Just for clarification, shall I replace the comment mentioned in change log with "no change"? >> >> drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++--- >> drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++ >> 2 files changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c >> index bdc3791..f45d093 100644 >> --- a/drivers/net/wireless/realtek/rtlwifi/base.c >> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c >> @@ -422,9 +422,9 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw) >> hw->extra_tx_headroom = RTL_TX_HEADER_SIZE; >> >> /* TODO: Correct this value for our hw */ >> - /* TODO: define these hard code value */ >> - hw->max_listen_interval = 10; >> - hw->max_rate_tries = 4; >> + /* defined these hard code values */ >> + hw->max_listen_interval = MAX_LISTEN_INTERVAL; >> + hw->max_rate_tries = MAX_RATE_TRIES; > > Like Larry said, the comment does not make any sense. Please remove it > and send v3. > > -- > Kalle Valo Souptick
