On Thu, 2017-06-22 at 07:43 -0700, Ben Greear wrote: > > On 06/21/2017 11:24 PM, Johannes Berg wrote: > > On Wed, 2017-06-21 at 17:02 -0700, Ben Greear wrote: > > > I think a comment for the above code block would be warranted > > > (and > > > for ath10k as well). > > > > > > I guess this is the part about dequeueing the frames immediately? > > > > Yeah, I figured it was pretty obvious, but I can add a comment :) > > It is fairly obvious today, but 6 months from now when someone tries > yet again to figure out WTF is ath10k doing, it will be one more > piece of mystery code! :-) Turns out this won't work well, I had misunderstood the TXQ code. We do need queueing for these frames, we just do it on the pending thing in mac80211... that's rather awful, and means we have to integrate much deeper with ath9k/ath10k to make any progress here. johannes
