> Not related to your patch but qtnf_map_bar() should be changed not to > return NULL. When functions return both NULL and error pointers the > NULL is supposed to be a special type of success return. Here it is > just a fail return where we forgot to set the error code to > ERR_PTR(-ENOMEM). Thanks for reporting! FWIW it is not a bug, all the checks of pci maps are in place. Though having both ERR_PTR and NULL in return indeed looks confusing. We will add a fix in the upcoming cleanup series. Regards, Sergey