On Fri, 2017-06-16 at 05:04 -0700, Joe Perches wrote: > Perhaps > > skb_put_data(skb, &c, sizeof(c)) > > as that avoids api expansion. Hmm. Perhaps not. That wouldn't work very well for constants when some variant like skb_putchar/skb_put_u8 works perfectly. I still think skb_putchar is nicer naming, but perhaps the skb_put_u<size> is more amenable to use with constants.