Search Linux Wireless

[mac80211-next:skb-put-zero 5/5] drivers/net/ppp/ppp_async.c:805:3: error: invalid use of void expression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git skb-put-zero
head:   f18c9b85b5d68bb029dc1f8c82bae33632d6f485
commit: f18c9b85b5d68bb029dc1f8c82bae33632d6f485 [5/5] networking: make skb_push & __skb_push return void*
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout f18c9b85b5d68bb029dc1f8c82bae33632d6f485
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All error/warnings (new ones prefixed by >>):

   drivers/net/ppp/ppp_async.c: In function 'process_input_packet':
>> drivers/net/ppp/ppp_async.c:805:19: warning: dereferencing 'void *' pointer
      skb_push(skb, 1)[0] = 0;
                      ^
>> drivers/net/ppp/ppp_async.c:805:3: error: invalid use of void expression
      skb_push(skb, 1)[0] = 0;
      ^
--
   drivers/net/ppp/ppp_synctty.c: In function 'ppp_sync_input':
>> drivers/net/ppp/ppp_synctty.c:714:19: warning: dereferencing 'void *' pointer
      skb_push(skb, 1)[0] = 0;
                      ^
>> drivers/net/ppp/ppp_synctty.c:714:3: error: invalid use of void expression
      skb_push(skb, 1)[0] = 0;
      ^
--
   drivers/net/ppp/pptp.c: In function 'pptp_rcv_core':
>> drivers/net/ppp/pptp.c:331:20: warning: dereferencing 'void *' pointer
       skb_push(skb, 1)[0] = 0;
                       ^
>> drivers/net/ppp/pptp.c:331:4: error: invalid use of void expression
       skb_push(skb, 1)[0] = 0;
       ^

vim +805 drivers/net/ppp/ppp_async.c

^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  789  		fcs = PPP_FCS(fcs, *p++);
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  790  	if (fcs != PPP_GOODFCS)
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  791  		goto err;	/* bad FCS */
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  792  	skb_trim(skb, skb->len - 2);
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  793  
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  794  	/* check for address/control and protocol compression */
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  795  	p = skb->data;
7c5050e3 drivers/net/ppp_async.c Paul Mackerras 2007-04-19  796  	if (p[0] == PPP_ALLSTATIONS) {
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  797  		/* chop off address/control */
7c5050e3 drivers/net/ppp_async.c Paul Mackerras 2007-04-19  798  		if (p[1] != PPP_UI || skb->len < 3)
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  799  			goto err;
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  800  		p = skb_pull(skb, 2);
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  801  	}
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  802  	proto = p[0];
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  803  	if (proto & 1) {
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  804  		/* protocol is compressed */
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16 @805  		skb_push(skb, 1)[0] = 0;
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  806  	} else {
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  807  		if (skb->len < 2)
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  808  			goto err;
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  809  		proto = (proto << 8) + p[1];
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  810  		if (proto == PPP_LCP)
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  811  			async_lcp_peek(ap, p, skb->len, 1);
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  812  	}
^1da177e drivers/net/ppp_async.c Linus Torvalds 2005-04-16  813  

:::::: The code at line 805 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux