On Tue, Jun 13, 2017 at 12:17 PM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > Amitkumar Karwar <amitkarwar@xxxxxxxxx> writes: > >> Currently macros are used for FSM states. We will replace >> it with enum so that new state can be added easily without >> worrying about macro value. >> >> Signed-off-by: Amitkumar Karwar <amit.karwar@xxxxxxxxxxxxxxxxxx> > > From and Signed-off-by does not match (gmail.com vs redpinesignals.com). > I suggest that you add a separate From line to the commit log containing > redpinesignals.com, this way you can still submit patches via gmail.com. Sure. I will follow this for my future patches. > > Also your name in patchwork is not capitalised (patchwork is idiotic and > takes the name from patchwork user data and not from the patch): > > [1/6] rsi: add usb RS9113 chipset support 2017-06-02 amit karwar New > [2/6] rsi: use enum for FSM states 2017-06-02 amit karwar New > [3/6] rsi: Register interrupt handler before firmware load 2017-06-02 amit karwar New > [4/6] rsi: receive path enhancement for RS9113 2017-06-02 amit karwar New > [5/6] rsi: configure new boot parameters to device 2017-06-02 amit karwar New > [6/6] rsi: add tx frame for common device configuration 2017-06-02 amit karwar New > > To fix that could you please register to patchwork and capitalise your > name correctly? You have only one chance, patchwork doesn't allow users > edit the name afterwards, so don't do any typos :) Thanks. I have registered with patchwork and corrected my name. Regards, Amitkumar Karwar
