Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> wrote: > When request firmware fails, brcmf_ops_sdio_remove is being called and > brcmf_bus freed. In such circumstancies if you do a suspend/resume cycle > the kernel hangs on resume due a NULL pointer dereference in resume > function. > > Steps to reproduce the problem: > - modprobe brcmfmac without the firmware > brcmfmac mmc1:0001:1: Direct firmware load for brcm/brcmfmac4354-sdio.bin > failed with error -2 > - do a suspend/resume cycle (echo mem > /sys/power/state) > > Protect against the NULL pointer derefence by checking if dev_get_drvdata > returned a valid pointer. > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> My understanding is that there's a new version of this patch which fixes the issue. If not, let me know. Patch set to Superseded. -- https://patchwork.kernel.org/patch/9743159/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches