Hi Colin, > -----Original Message----- > From: Colin King [mailto:colin.king@xxxxxxxxxxxxx] > Sent: 2017年6月2日 16:57 > To: Amitkumar Karwar; Nishant Sarmukadam; Ganapathi Bhat; Xinming Hu; > Kalle Valo; linux-wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx > Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: [EXT] [PATCH][-next] mwifiex: make function > mwifiex_ret_pkt_aggr_ctrl static > > External Email > > ---------------------------------------------------------------------- > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > function mwifiex_ret_pkt_aggr_ctrl can be made static as it does not need to > be in global scope. > > Cleans up sparse warning: "symbol 'mwifiex_ret_pkt_aggr_ctrl' was not > declared. Should it be static?" Yes, it should be static, Thanks, Regards, Simon > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- > drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c > b/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c > index 3348fb3a7514..2945775e83c5 100644 > --- a/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c > +++ b/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c > @@ -1154,8 +1154,8 @@ static int mwifiex_ret_chan_region_cfg(struct > mwifiex_private *priv, > return 0; > } > > -int mwifiex_ret_pkt_aggr_ctrl(struct mwifiex_private *priv, > - struct host_cmd_ds_command *resp) > +static int mwifiex_ret_pkt_aggr_ctrl(struct mwifiex_private *priv, > + struct host_cmd_ds_command *resp) > { > struct host_cmd_ds_pkt_aggr_ctrl *pkt_aggr_ctrl = > &resp->params.pkt_aggr_ctrl; > -- > 2.11.0
