Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > We have the number of longs, but we should be calculating the number of > bytes needed. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/net/wireless/intersil/p54/fwio.c b/drivers/net/wireless/intersil/p54/fwio.c > index 4ac6764f4897..3076f646c829 100644 > --- a/drivers/net/wireless/intersil/p54/fwio.c > +++ b/drivers/net/wireless/intersil/p54/fwio.c > @@ -176,8 +176,9 @@ int p54_parse_firmware(struct ieee80211_hw *dev, const struct firmware *fw) > * keeping a extra list for uploaded keys. > */ > > - priv->used_rxkeys = kzalloc(BITS_TO_LONGS( > - priv->rx_keycache_size), GFP_KERNEL); > + priv->used_rxkeys = kcalloc(BITS_TO_LONGS(priv->rx_keycache_size), > + sizeof(long), > + GFP_KERNEL); > > if (!priv->used_rxkeys) > return -ENOMEM; Patch applied to wireless-drivers-next.git, thanks. c239838fbd6d p54: allocate enough space for ->used_rxkeys -- https://patchwork.kernel.org/patch/9714501/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
