On Fri, May 19, 2017 at 09:22:59PM -0500, Larry Finger wrote: > On 05/19/2017 04:25 PM, Dan Carpenter wrote: > > We only want to disable this if bt_disable_cnt is >= 2. > > > > Fixes: f66509e3d7c2 ("rtlwifi: btcoex: Remove 23b 1ant configuration parameter") > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > --- > > Btw, that patch also introduced Sparse warning but I don't know how to > > address it. > > > > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c:1432:63: warning: odd constant _Bool cast (2 becomes 1) > > I agree that bt_disabled needs to be initialized. Actually, I would have > expected an unitialized variable warning out of gcc. > > Earlier today, I finished applying the rest of the btcoex patches from > Realtek and now have a clean Sparse run. I never saw that message, and I > certainly do not understand it either. > > Larry I had another look and I figured it out. I'll send a patch. regards, dan carpenter