On Tue, May 16, 2017 at 01:58:56PM +0200, Johannes Berg wrote: > On Tue, 2017-05-16 at 13:55 +0200, Stanislaw Gruszka wrote: > > > > In rt2x00 driver we use poor convention in other kind of registers > > accessors like bbp, mac, eeprom. I dislike to changing only rfcsr > > accessors and leaving others in the old way. And changing all > > accessors would be massive and error prone change, which I'm not > > prefer either. > > That's a stupid argument, but for the sake of it - the conversion can > easily be done with coccinelle/spatch without being "error prone". Sure, but still I think it would be preferable to fix newly added rt2800_bw_filter_calibration() function, instead of ancient rfcsr accessors. Stanislaw
