Igor Mitsyanko <igor.mitsyanko.os@xxxxxxxxxxxxx> writes: > On 03/11/2017 12:04 PM, Igor Mitsyanko wrote: >> This patch adds support for new FullMAC WiFi driver for Quantenna >> QSR10G chipsets. > > Hi all, > this patch is pending for a while now, does it require more work > (except for what Christian mentioned)? I just did a diff between v4 and v5 and looking good at least to me. Do others have more comments/concerns? Now would be a very good time to submit a new driver as we are getting close to the rc1 release. This way it gets plenty of testing time in linux-next. So sooner you can submit v6 the better. >> QSR10G (aka Pearl) is Quantenna's 8x8, 160M, 11ac offering. >> QSR10G supports 2 simultaneous WMACs - one 5G and one 2G. >> 5G WMAC supports 160M, 8x8 configuration. FW supports >> up to 8 concurrent virtual interfaces on each WMAC. >> >> Patch introduces 2 new drivers: >> - qtnfmac.ko for interfacing with kernel wireless core >> - qtnfmac_pearl_pcie.ko for interfacing with hardware over PCIe interface Please mention in the commit log also what modes (AP, managed, monitor etc) are supported. But PLEASE edit your quotes, the insane 8000 line quote makes my use of patchwork[1] difficult: https://patchwork.kernel.org/patch/9619075/ [1] And I do almost all of my maintainer work via patchwork so this habit of not editing quotes is a big hindrance for me. And unfortunately it's getting more popular :( -- Kalle Valo