Steve deRosier <derosier@xxxxxxxxx> writes: > On Wed, Apr 26, 2017 at 12:54 PM, James Hughes > <james.hughes@xxxxxxxxxxxxxxx> wrote: >> On 26 April 2017 at 19:03, Arend Van Spriel >> <arend.vanspriel@xxxxxxxxxxxx> wrote: >>> >>> >>> On 26-4-2017 17:44, Steve deRosier wrote: >>>> On Wed, Apr 26, 2017 at 1:53 AM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: >>>>> Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> wrote: >>>>>> An issue was found brcmfmac driver in which a skbuff in .start_xmit() >>>>>> callback was actually cloned. So instead of checking for sufficient >>>>>> headroom it should also be writable. Hence use skb_cow_head() to >>>>>> check and expand the headroom appropriately. >>>>>> >>>>>> Signed-off-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> >>>>> >>>>> Steve, would you have time to run a quick test with this? >>>>> >>>>> Patch set to Deferred. >>>>> >>>> >>>> Happy to give it a quick spin on both of my platforms. >>>> > > @ Arend and James, thanks for the info. I understand it, but > unfortunately I can't seem to replicate the problems on my platforms > with the limited time I have available to test it. It also may have to > do with my platforms having special custom bridging related code, or > just me having setup too simple of a test. > > That said... > > @Kalle: I have tested on both my 6004 and 6003 platforms. I didn't > notice any incorrect behavior in my testing. But I don't have a test > setup that would have shown the original problem as reported on the > brcm driver so I can't say that the change actually _fixes_ anything. > Only that in my testing it doesn't seem to break anything. > > Tested-by: Steve deRosier <derosier@xxxxxxxxx> Yeah, I was mostly worried about regression. I didn't expect you to replicate the bug. Thanks for testing, I'll add this patch to my queue. -- Kalle Valo
