> > > +Please note that the current Linux kernel does not enable AP mode, so a > > > +simple patch is needed to enable AP mode selection: > > > +http://johannes.sipsolutions.net/patches/kernel/all/LATEST/006-allow-ap-vlan-modes.patch > > > > Ok, once this code is in I'll add a hunk to my patch there that removes > > this note. > > By the way, what's the current plan on applying this patch to allow AP > modes to be enabled? I would assume they are still disabled because AP > functionality is not yet complete, but is there a clear set of features > that need to be added/fixed before this change goes in? Well mostly the channel stuff, basic rate sets, rts/cts, short slot and stuff like that. See http://wireless.kernel.org/en/developers/todo-list#APsupport > > Since you never set "ack" anywhere else, you could just say > > ack = memcmp(...) == 0; > > This is in a loop, so ack must not be cleared back to zero if it was > once set to 1 for an earlier radio.. Oh, right, sorry. > > > +static void mac80211_hwsim_beacon_tx(void *arg, u8 *mac, > > > + struct ieee80211_vif *vif) > > > Maybe there should be a helper function for all this? It seems mostly > > duplicated. > > Yes, I was hoping to do this first, but there were some differences that > I did not want to deal with at the time. I'll take a closer look at > moving that to a shared function. It will likely make this bit slower, > but then again, I'm not really concerned about how fast this sort of > simulation code will work; it'll be much faster than actually going over > the air to another host for sure ;-). Heh. Well I didn't look too closely so if this isn't easy to do I guess you shouldn't bother, it just seemed to be very similar to me on first sight. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
