On 24-4-2017 20:09, Eric Dumazet wrote: > On Mon, 2017-04-24 at 14:03 +0100, James Hughes wrote: >> The driver was making changes to the skb_header without >> ensuring it was writable (i.e. uncloned). >> This patch also removes some boiler plate header size >> checking/adjustment code as that is also handled by the >> skb_cow_header function used to make header writable. >> >> This patch depends on >> brcmfmac: Ensure pointer correctly set if skb data location changes >> >> Signed-off-by: James Hughes <james.hughes@xxxxxxxxxxxxxxx> >> --- >> Changes in v2 >> Makes the _cow_ call at the entry point of the skb in to the >> stack, means only needs to be done once, and error handling >> is easier. >> Split a separate minor bug fix off to a separate patch (which >> this patch depends on) > > Best way to handle dependencies is to send a patch series. > > 1/2 brcmfmac: Ensure pointer correctly set if skb data location changes > 2/2 brcmfmac: Make skb header writable before use There is actually no real dependency. Both are valid fixes of course but either one applies to wireless-drivers-next/master on its own. Regards, Arend
