On Thu, 2017-04-20 at 09:55 +0300, Kalle Valo wrote: > Luca Coelho <luca@xxxxxxxxx> writes: > diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-a000.c > > b/drivers/net/wireless/intel/iwlwifi/iwl-a000.c > > index 6d745c36f1d8..097cb45c8ad9 100644 > > --- a/drivers/net/wireless/intel/iwlwifi/iwl-a000.c > > +++ b/drivers/net/wireless/intel/iwlwifi/iwl-a000.c > > @@ -55,7 +55,7 @@ > > #include "iwl-agn-hw.h" > > > > /* Highest firmware API version supported */ > > -#define IWL_A000_UCODE_API_MAX 31 > > +#define IWL_A000_UCODE_API_MAX 30 > > Good that you dropped this. I was a bit worried that if it the API bump > was too soon and inconvenient for the users. Yes, we usually bump it up internally *before* we get all the actual API changes in the firmware, so both the driver and the FW evolve together. So, in practice, I should bump the API to 30 upstream when we reach the bump to 31 internally (which means 30 is frozen at that point). -- Cheers, Luca.