Search Linux Wireless

Re: [PATCH V2 3/3] cfg80211: Share Channel DFS state across wiphys of same DFS domain

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 18 April 2017 04:20 PM, Johannes Berg wrote:
>
>> +void regulatory_propagate_dfs_state(struct wiphy *wiphy,
>> +				    struct cfg80211_chan_def
>> *chandef,
>> +				    enum nl80211_dfs_state
>> dfs_state,
>> +				    enum nl80211_radar_event event)
>> +{
>> +	struct cfg80211_registered_device *rdev;
>> +
>> +	ASSERT_RTNL();
>> +
>> +	if (WARN_ON(!cfg80211_chandef_valid(chandef)))
>> +		return;
>> +
>> +	if (WARN_ON(!(chandef->chan->flags & IEEE80211_CHAN_RADAR)))
>> +		return;
>
>
> This warn on reliably triggers for me when I run the "ap_vht160" hwsim
> test from wpa_supplicant.
>
> I think there might be some confusion about this when parts of the 160
> MHz channel require radar and parts don't? But I haven't looked into
> this at all.

Correct, when some part of a bigger bandwidth channel falls in DFS channel range
channel definition of that channel's center freq is may not be a radar channel and
bailing out based on the channel flag there is not right.

Sorry for the bug and thanks for reporting it.

>
> Please send me a fix ASAP so Jouni doesn't shout at me for test
> failures :)

Sure.

Vasanth




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux