I have made some basic testing (AP scanning) with this patchset and as far as I can see they haven't broken anything. I have not exercised all code (like error interrupt handling etc.) so those patches might contain bugs (I noticed a FIXME comment in one of them). I will review those patches and get back with more comments (if I find anything). Erik On 2017-04-05 09:06, Kalle Valo wrote:
Using ath10k_sdio_io() and ath10k_sdio_read_write_sync() are just confusing. Refactor the code by following the plan outlined below. I'm planning to fold all these seven patches into Erik's patch adding sdio.c[1] so I didn't write any commit logs. I'm just submitting these separately to make it easier to review the changes. Kalle ath10k_sdio_read_write_sync(): X HIF_RD_SYNC_BLOCK_FIX -> ath10k_sdio_readsb() X HIF_RD_SYNC_BYTE_INC -> ath10k_sdio_read(), ath10k_sdio_read32() X HIF_WR_SYNC_BYTE_FIX -> ath10k_sdio_writesb32() X HIF_WR_SYNC_BYTE_INC -> ath10k_sdio_write() ath10k_sdio_prep_async_req(): X HIF_WRITE -> HIF_WR_SYNC_BYTE_INC -> ath10k_sdio_write() ath10k_sdio_read/write32(): sdio_readl()/sdio_writel() (those use endian macros) ath10k_sdio_writesb32(): kmalloc() sdio_writesb(len) kfree() ath10k_sdio_readsb(): len = round_down(len, ar_sdio->mbox_info.block_size); sdio_readsb(len) ath10k_sdio_read(): sdio_memcpy_fromio() ath10k_sdio_write(): sdio_memcpy_toio() [1] https://patchwork.kernel.org/patch/9626001/ --- Kalle Valo (7): ath10k: add ath10k_sdio_write32/read32() ath10k: add ath10k_sdio_writesb() ath10k: add ath10k_sdio_read() ath10k: add ath10k_sdio_write() ath10k: add ath10k_sdio_readsb() ath10k: convert __ath10k_sdio_write_async() to use ath10k_sdio_write() ath10k: remove unused sdio wrappers drivers/net/wireless/ath/ath10k/sdio.c | 419 +++++++++++++++++--------------- drivers/net/wireless/ath/ath10k/sdio.h | 40 --- 2 files changed, 219 insertions(+), 240 deletions(-) _______________________________________________ ath10k mailing list ath10k@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/ath10k
