Marcin Rokicki <marcin.rokicki@xxxxxxxxx> wrote: > Both macros are used internally to convert incomming parameters > to strings in a switch case statement. > > Current implementation gives following output from checkpatch.pl: > - ERROR: Macros with complex values should be enclosed in parentheses > - WARNING: Macros with flow control statements should be avoided > > Fix them by modify local variable in the middle and just return at the end. > > Btw add const to function that return string literals > > Signed-off-by: Marcin Rokicki <marcin.rokicki@xxxxxxxxx> I don't really see how this improves anything. We don't need to fix every checkpatch warning as not all of them always make sense. That's why I have the ath10k-check script so that I can disable such checkpatch warnings. https://wireless.wiki.kernel.org/en/users/drivers/ath10k/codingstyle#checking_code Patch set to Rejected. -- https://patchwork.kernel.org/patch/9586357/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
