This started out with the observation that the nfcmrvl_uart driver unconditionally dereferenced the tty class device despite the fact that not every tty has an associated struct device (Unix98 ptys). Some further changes were needed in the common nfcmrvl code to fully address this, some of which also incidentally fixed a few related bugs (e.g. resource leaks in error paths). While fixing this I stumbled over a regression in NFC core that lead to broken registration error paths and misnamed workqueues. Note that this has only been tested by configuring the n_hci line discipline for different ttys without any actual NFC hardware connected. Johan Changes in v2 - fix typo in commit message (1/8) - release reset gpio in error paths (3/8) - fix description of patch impact (3/8) - allow gpio 0 to be used for reset signalling (8/8, new) Johan Hovold (8): NFC: fix broken device allocation NFC: nfcmrvl_uart: add missing tty-device sanity check NFC: nfcmrvl: do not use device-managed resources NFC: nfcmrvl: use nfc-device for firmware download NFC: nfcmrvl: fix firmware-management initialisation NFC: nfcmrvl_uart: fix device-node leak during probe NFC: nfcmrvl_usb: use interface as phy device NFC: nfcmrvl: allow gpio 0 for reset signalling drivers/nfc/nfcmrvl/fw_dnld.c | 7 ++++-- drivers/nfc/nfcmrvl/main.c | 40 +++++++++++++++++++---------------- drivers/nfc/nfcmrvl/uart.c | 11 ++++++---- drivers/nfc/nfcmrvl/usb.c | 4 +--- include/linux/platform_data/nfcmrvl.h | 2 +- net/nfc/core.c | 31 +++++++++++++++------------ net/nfc/nci/core.c | 3 +-- 7 files changed, 55 insertions(+), 43 deletions(-) -- 2.12.2
