Search Linux Wireless

Re: [PATCH] nl80211: fix dumpit error path RTNL deadlocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Date: Wed, 15 Mar 2017 14:29:13 +0100

> From: Johannes Berg <johannes.berg@xxxxxxxxx>
> 
> Sowmini pointed out Dmitry's RTNL deadlock report to me, and it turns out
> to be perfectly accurate - there are various error paths that miss unlock
> of the RTNL.
> 
> To fix those, change the locking a bit to not be conditional in all those
> nl80211_prepare_*_dump() functions, but make those require the RTNL to
> start with, and fix the buggy error paths. This also let me use sparse
> (by appropriately overriding the rtnl_lock/rtnl_unlock functions) to
> validate the changes.
> 
> Reported-by: Sowmini Varadhan <sowmini.varadhan@xxxxxxxxxx>
> Reported-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>

Johannes, I assume I will get this in a future pull request?



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux