On Wed, 2017-03-08 at 17:57 +0100, Hans de Goede wrote:
> Hi,
And hello back to you.
> On 08-03-17 17:34, Joe Perches wrote:
> > On Wed, 2017-03-08 at 09:23 +0100, Hans de Goede wrote:
> > > Using pr_err for things which are not errors is a bad idea. E.g. it
> > > will cause the plymouth bootsplash screen to drop back to the text
> > > console so that the user can see the error, which is not what we
> > > normally want to happen.
> > >
> > > Instead add a new brcmf_info macro and use that.
> > >
> > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > > ---
> > > Changes in v2:
> > > -Fix brcm_err typo (should be brcmf_err) in CONFIG_BRCM_TRACING case
> > > Changes in v3:
> > > -Use do { } while (0) around macro
> >
> > why? Single statement macros do not need a do/while
>
> Because Arend ask me to during review of v2.
Well, maybe Arend should learn that single statement macros
don't need do/while guards and that do/while guards are
generally not used in the kernel for single statements.
